search

laravel / dusk

Laravel Dusk provides simple end-to-end testing and browser automation.
https://laravel.com/docs/dusk
MIT License
1.87k stars 320 forks source link

update DuskTestCase.stub for define github or local #1101

Closed tszyuloveyou closed 4 months ago

tszyuloveyou commented 4 months ago

For https://github.com/laravel/docs/pull/9601 ref: https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables

driesvints commented 4 months ago

Thanks. I'm not sure why the stub changes were necessary. I removed these.

driesvints commented 4 months ago

Actually, I'm gonna revert this one because this step actually tested the command itself which we aren't doing anymore after this PR.

crynobone commented 4 months ago

I assume this changes to make way for alternative ChromeDriver such as Firefox and Safari but we should see an actual use case first and maybe look at how Livewire project does it with Testbench Dusk