laravel / dusk

Laravel Dusk provides simple end-to-end testing and browser automation.
https://laravel.com/docs/dusk
MIT License
1.87k stars 320 forks source link

[7.x] Fix for change in chromedriver archive structure #1116

Closed aleahy closed 1 month ago

aleahy commented 1 month ago

This PR fixes the bug that exists in version 7.x due to the change in the archive structure for the chrome-driver.

driesvints commented 3 weeks ago

@aleahy v7 isn't maintained any longer. Please upgrade to v8

u01jmg3 commented 3 weeks ago

@driesvints: should GitHub Actions be set to autoclose PRs raised against branches no longer receiving support?

driesvints commented 3 weeks ago

@u01jmg3 I've thought of developing such a flow but haven't found the time yet.

driesvints commented 3 weeks ago

Can maybe become part of https://github.com/laravel/.github/blob/main/.github/workflows/pull-requests.yml as a new auto-close flow that closes PR's against branches that aren't the default branch. Also, maintainers should still always be able to send PR's to any branch.