Closed dammy001 closed 7 months ago
This is similar to https://github.com/laravel/echo/pull/356 😁
Thanks for the PR!
I'm all for adding the type definitions and eliminating as many any
as possible!
There are quite a few additional opinionated changes in this PR, and some bundling changes that have me concerned, given how often stuff like this has broken peoples' apps.
For example, the IIFE changes have me worried that this PR reintroduces the issue solved in #344.
Mark as ready for review when ready for me to review again please.
Thanks for the PR!
I'm all for adding the type definitions and eliminating as many
any
as possible!There are quite a few additional opinionated changes in this PR, and some bundling changes that have me concerned, given how often stuff like this has broken peoples' apps.
For example, the IIFE changes have me worried that this PR reintroduces the issue solved in #344.
@jessarcher i get your point about the IIFE breaking change, I'll revert the declaration part.
@jessarcher please take a look at this again. potential IIFE issue has been reverted
@dammy001 There's still an awful lot going on in this PR unrelated to the PR title.
Is it possible to just add the options types without installing extra packages and reconfiguring the entire build process and module set-up?
@dammy001 have you seen Jess' questions? Are you still working on this?
@driesvints I'll work on the changes today.
@dammy001 feel free to resend this once you have more time
… files
The bundle size has reduced also.