laravel / folio

Page based routing for Laravel.
MIT License
568 stars 46 forks source link

[1.x] Namespace make command #134

Closed timacdonald closed 5 months ago

timacdonald commented 6 months ago

Docs: https://github.com/laravel/docs/pull/9510

Namespaces folio's make command.

It is currently inconsistent with the rest of the ecosystem.

make:folio
pennant:feature
dusk:make
dusk:page
dusk:component

make:folio => folio:page

folio:page
pennant:feature
dusk:make
dusk:page
dusk:component

folio:make is also an option, but I liked that the command still expresses what it makes, i.e., a page.

inmanturbo commented 6 months ago

@timacdonald for some reason every time I go to creat a folio "page" I type

php artisan folio:route "path/to/file"

😅

Idk why. In a way I guess it's like adding a route. Incidentally livewire/volt is very similar to the current signature make:volt.

Anyway it breaks the signature but it won't break applications. Namespacing is a good idea and an improvement, I think.

inmanturbo commented 6 months ago

Honestly I just wish you could pass a stub to the underlying make command as an option. I might work on that if I get a chance. Always want different stubs for different types of pages (or components)