laravel / forge-cli

The Laravel Forge CLI.
https://forge.laravel.com
MIT License
227 stars 35 forks source link

Add support for displaying tags on site and server command output #34

Closed michaeldyrynda closed 3 years ago

michaeldyrynda commented 3 years ago

This adds site and server tags to relevant command output.

This does rely on a tags() method introduced on the Site and Server resources to handle converting to strings consistently, so tests have been updated to use the relevant resource where appropriate.

Depends on laravel/forge-sdk#126

Screen Shot 2021-10-01 at 12 12 05 pm

Screen Shot 2021-10-01 at 12 08 44 pm

Screen Shot 2021-10-01 at 12 12 22 pm

Screen Shot 2021-10-01 at 12 10 43 pm

taylorotwell commented 3 years ago

@michaeldyrynda seems like some of the GitHub actions are failing. Can you mark as ready when that is fixed? Or maybe @nunomaduro can look?

michaeldyrynda commented 3 years ago

They’re failing because this PR relies on changes added in the forge-sdk repo linked in the description. I’ve got them all passing with local versions of both repos.

Happy to work with Nuno on getting this ready!

jbrooksuk commented 3 years ago

I've merged the PHP SDK changes required for this now 👍🏻 We will need to do a release though.