Documentation: Add `two_factor_secret`, `two_factor_recovery_codes`, to `User::$hidden`

laravel / fortify

Backend controllers and scaffolding for Laravel authentication.

https://laravel.com/docs/fortify

MIT License

1.61k stars 294 forks source link

Documentation: Add `two_factor_secret`, `two_factor_recovery_codes`, to `User::$hidden` #170

Closed LeoniePhiline closed 3 years ago

LeoniePhiline commented 3 years ago

Fortify Version: 1.7.2
Laravel Version: 8.19.0

Description:

Hi there!

While reading through the Fortify code and documentation, I found no automagic measure (e.g. in the TwoFactorAuthenticatable trait) and no hint in the documentation to add 'two_factor_secret' and 'two_factor_recovery_codes' to the User model's $hidden property.

Since damage can be avoided, I makes sense instructing users accordingly or auto-hiding these attributes.

driesvints commented 3 years ago

Feel free to send a PR to the docs.