Bug with "whereDate" methods

[projct1]

• Laravel Version: 5.4.19

Description:

$builder->whereTime('remind_at', 'between', [10, 12]);

This not working, because generates this sql: ... and time(remind_at) between 10 Of couse, we can add methods whereDateBetween, whereTimeBetween, etc)

[Dylan-DPC-zz]

@rorc can you take the resulting query and run the query to see if you are getting your desired result?

[projct1]

@Dylan-DPC As u can see above, result query is and time(remind_at) between 10 (without 12) Actual result must be and time(remind_at) between 10 and 12

[Dylan-DPC-zz]

what happens with whereBetween?

[stemis]

@rorc According to the laravel docs, whereTime only accepts an int as the third parameter, it seems like whereTime was never designed to be used with the between operator

After some testing, none of the functions that use Illuminate\Database\Query\Builder::addDateBasedWhere, accept an array as third argument

https://laravel.com/api/5.4/Illuminate/Database/Query/Builder.html#method_whereTime

[projct1]

@stemis Yea, and we can improve this, adding between to $operator?

[Dylan-DPC-zz]

@rorc you can use whereBetween('time', 10, 12);