search

laravel / framework

The Laravel Framework.
https://laravel.com
MIT License
32.21k stars 10.9k forks source link

Fix support custom URLs for S3 storage #24591

Closed finagin closed 5 years ago

finagin commented 6 years ago

Description:

AWS-SDK-S3 don't support url. Needs endpoint configuration variable.

This way works only for FilesystemAdapter::url, but not for other methods like exists, put, temporaryUrl etc. with S3 adapter.

Steps To Reproduce:

  1. In config/filesystems.php set s3.url not AWS S3 like https://hb.bizmrg.com
  2. Call Storage::cloud()->put('test/test.txt', 'cloud');

Steps To Solution:

  1. Revert laravel/framework#22037
  2. Fix laravel/laravel#4483 change url to endpoint
finagin commented 6 years ago

laravel/laravel#4686 and laravel/framework#24593 must be merged together

driesvints commented 5 years ago

Going to close this as the PRs were closed as well. I think it's best if you lay down your use case at https://github.com/laravel/ideas first to gather support and try again with the info Taylor has requested.