DB::beginTransaction() without DB::rollBack() disables flash messages.

poldon commented 5 years ago

Laravel Version: 5.8.5
PHP Version: 7.2.14
Database Driver & Version: mysqlnd 5.0.12 & pdo_mysql 7.2.14

Description:

If I call DB::beginTransaction() in a controller but redirect without calling DB::rollBack(), my flash messages don't appear on the new page. For example, in a shopping cart, I start a transaction but redirect to the payment page when the credit card payment fails. The payment error doesn't appear unless I call DB::rollBack() first. This happens on both Laravel 5.7 and 5.8.

Steps To Reproduce:

This fails:

    DB::beginTransaction();

    return redirect("/checkout/payment")->withInput($request->all())->withFlashDanger("Credit Card Number is required.");

This works:

    DB::beginTransaction();

    DB::rollBack();

    return redirect("/checkout/payment")->withInput($request->all())->withFlashDanger("Credit Card Number is required.");