laravel / framework

The Laravel Framework.
https://laravel.com
MIT License
32.55k stars 11.03k forks source link

Incompatibility of assertSoftDeleted with softDelete trait #30110

Closed Theremsoe closed 5 years ago

Theremsoe commented 5 years ago

Description:

Incompatibility between assertSoftDeleted with softDelete when you define a custom name column.

Steps To Reproduce:

X-Coder264 commented 5 years ago

Unfortunately yes, the deleted_at column is currently hardcoded in the PHPUnit constraint class https://github.com/laravel/framework/blob/v6.0.4/src/Illuminate/Foundation/Testing/Constraints/SoftDeletedInDatabase.php#L54

driesvints commented 5 years ago

Hmm, this indeed seems unwanted.

driesvints commented 5 years ago

PR merged

Theremsoe commented 5 years ago

Thanks guys.