laravel / framework

The Laravel Framework.
https://laravel.com
MIT License
32.7k stars 11.06k forks source link

[Proposal] #3134

Closed jziolkowskipolcode closed 10 years ago

jziolkowskipolcode commented 10 years ago

Add support for multicolumn primary key for Eloquent ORM.

GrahamCampbell commented 10 years ago

Could you write an implementation? That's normally how proposals work.

robclancy commented 10 years ago

No it isn't. You describe a use case or something. And like use a title.

Also this has been suggested before and denied I think, maybe. I know it has been suggested anyway.

GrahamCampbell commented 10 years ago

It does seem to work like that - https://github.com/laravel/framework/issues/3119#issuecomment-31582557 and https://github.com/laravel/framework/issues/3075#issuecomment-31323276.

JoostK commented 10 years ago

No it does not, the point of proposals is to avoid having people put a lot of time in actually implementing something to find out that it will not be accepted into the framework. Sometimes things are hard to understand without code or only small changes, so then a PR may make sense.

This feature would require a very large update of a lot of database classes, and I bet it would introduce a ton of bugs which nobody is prepared to fix.

GrahamCampbell commented 10 years ago

I'm sorry. I'll just shut up then.

robclancy commented 10 years ago

Wow are you new to the internet? Even though you know you are wrong you don't stop arguing about it. Pride man, where is your pride?!

GrahamCampbell commented 10 years ago

@robclancy Incase you haven't noticed, I apologized, and it was all over until you and your big gob rolled in to town.

robclancy commented 10 years ago

Wow rude.

GrahamCampbell commented 10 years ago

Wow rude - "Wow are you new to the internet?".

robclancy commented 10 years ago

Nah I'm a veteran.

GrahamCampbell commented 10 years ago

@robclancy Clearly - #3132.

robclancy commented 10 years ago

Y

taylorotwell commented 10 years ago

No plans to implement this at the current time.