HHVM Compatibility - Githubissues

laravel / framework

The Laravel Framework.

https://laravel.com

MIT License

32.55k stars 11.03k forks source link

HHVM Compatibility #3377

Closed fredemmott closed 10 years ago

fredemmott commented 10 years ago

Creating an issue to track this.

HHVM fixes: in FB internal branch. Should reach github master shortly, and tomorrow's release
Mockery fixes: in github master.

Mockery from master (or the next release) + tomorrow's HHVM release should get you a 100% pass rate.

So, TODO:

upgrade Mockery in composer.json
remove HHVM from allowed_failures in travis.yml ?

taylorotwell commented 10 years ago

Cool, what kind of fixes are in the internal branch? Mockery fixes sound good.

Has you team addressed the issues with the Predis library? https://github.com/nrk/predis ... I saw reports on Twitter have people have issues with that lib, which Laravel uses for our Redis session driver.

taylorotwell commented 10 years ago

I'm also fine with removing allowed_failures on HHVM build on Travis so we can keep a closer eye on things.

fredemmott commented 10 years ago

I've not specifically looked at Predis; we're prioritizing based on a mix of github and versioneye's metrics, and issues filed against HHVM.

No changes were made to HHVM specifically to support Laravel - however, the changes required to make Mockery and PHPUnit pass 100% also made it pass 100%. They're mostly related to reflection, autoloading, and ini_*() (HHVM doesn't have ini files)

taylorotwell commented 10 years ago

Gotcha. Thanks for all your work! I'm very excited about the future of HHVM.