Closed loduis closed 4 years ago
I realise this is probably my issue, but I'm getting an error on composer install
since this file was moved.
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
Script Illuminate\Foundation\ComposerScripts::postAutoloadDump handling the post-autoload-dump event terminated with an exception
In ClassLoader.php line 444:
include(/builds/<redacted>/<redacted>/vendor/composer/../laravel/framework/sr
c/Illuminate/Support/Arr.php): failed to open stream: No such file or direc
tory
$ php --version
PHP 7.4.10 (cli) (built: Sep 3 2020 19:59:29) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
$ composer --version
Composer 1.10.13 2020-09-09 11:46:34
It's only failing in CI (i.e. a fresh build with no cache or anything). On my local machine it's fine. I'll post back if I figure it out.
As is often the way, and as I suspected, the issue was mine, and I solved it moments after posting the above :joy:
There was another cache at play - the CI runner cache on GitLab. After clearing that, it built fine.
Hopefully this helps someone else!
@driesvints is this class aliased anywhere? The SupportArr test still references the old path but I can't seem to find any aliasing that would support that.
Hey @LukeTowers, what do you mean with
The SupportArr test still references the old path
Can you point out where?
@driesvints sure, see https://github.com/laravel/framework/blob/8.x/tests/Support/SupportArrTest.php#L6
That seems okay to me?
@driesvints it's referencing lluminate\Support\Arr
when the actual class is lluminate\Collections\Arr
. If lluminate\Support\Arr
is expected to work; my question is where is that connection between the non-existent lluminate\Support\Arr
class and the actual lluminate\Collections\Arr
class set up?
The Illuminate\Collections
namespace doesn't exists?
I do see there's two usages of it that was introduced in this PR but the OP accidentally used it while it should have been Support
. I'll send in a PR to fix that.
@driesvints ahh, I see! The collections stuff was split off into its own package but the namespace remained the same; that's the critical piece of information that I was missing. Specifically to answer my own question this line is what makes /src/Illuminate/Collections/Arr.php
available as Illuminate\Support\Arr
.
I can't find this class in the framework in version 8 previus version exists