search

laravel / framework

The Laravel Framework.
https://laravel.com
MIT License
32.21k stars 10.9k forks source link

When docs are printed, partially covered by an "Ads by Carbon" ad #38360

Closed barobba closed 3 years ago

barobba commented 3 years ago

Description:

I don't know who needs to see this issue or where to post it.

The bottom-right corner of printed pages are covered by an "Ads via Carbon" ad. This makes it impossible to read the full docs from a printed version because a portion of the sentences are covered up with an ad.

Steps To Reproduce:

Print out a few pages in the docs.

For example: https://laravel.com/docs/8.x/mail (print this)

driesvints commented 3 years ago

No plans to change this ourselves. You're always free to attempt a PR. Thanks

barobba commented 3 years ago

I didn't realize I could do PR!

I will take a look.

I found this: https://github.com/laravel/laravel.com-next

I assume this is what is currently used.

On Thu, Aug 12, 2021 at 9:22 AM Dries Vints @.***> wrote:

No plans to change this ourselves. You're always free to attempt a PR. Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/laravel/framework/issues/38360#issuecomment-897682240, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAC3FX7O6JHHG2RR5MGG7LT4PKK5ANCNFSM5CBKFRYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

barobba commented 3 years ago

Ok, I submitted a pull request.