laravel / framework

The Laravel Framework.
https://laravel.com
MIT License
32k stars 10.84k forks source link

Inconsistent timestamps format for User model on Logout #52086

Closed Aniket-IN closed 3 weeks ago

Aniket-IN commented 1 month ago

Laravel Version

10.45.0

PHP Version

8.2.18

Database Driver & Version

No response

Description

I noticed a weird issue, when a user tries to logout from my Laravel Application. Laravel updates the remember_token. Which results in Scout updating the data on it's index, and I noticed the timestamp format is not always same.

On that update Laravel sets $user->timestamps to false which disables the casting for created_at and updated_at fields. This line: https://github.com/laravel/framework/blob/e052cb83b0bbd73c0359d1ab3770c0d0a1831f23/src/Illuminate/Auth/EloquentUserProvider.php#L99

Which eventually leads to inconsistant format for the timestamp fields.

Usually the format is like this: 2023-09-05T18:23:38.000000Z but, only on that instance (when Laravel updates the remember_token) the format is like this: 2023-09-05 18:23:38

When Laravel updates the User model on Logout: image

When I update the User model from any other place: image

Steps To Reproduce

1) Start a new Laravel project with Breeze (Blade) 2) Configure Laravel Scout (any driver) 3) Register a User 4) Login to the dashboard 5) Create the toSearchableArray() method in User model, and add a dd($this->created_at)

    public function toSearchableArray(): array
    {
        dd($this->created_at);
    }

6) Now logout from the dashboard it will show the dd() output, (Note this 📝) 7) Next, from any other controller try updating a User User::find(1)->update(['name' => "Foo Bar"]); 8) Run this code, it will show the dd() output, (Note this 📝)

Compare the output of Step 6 and Step 8 Those should be different.

crynobone commented 1 month ago

Hey there, thanks for reporting this issue.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?

Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

driesvints commented 3 weeks ago

Closing this issue because it's inactive, already solved, old or not relevant anymore. Feel to open up a new issue if you're still experiencing this.