laravel / framework

The Laravel Framework.
https://laravel.com
MIT License
32.55k stars 11.03k forks source link

Checking custom validation messages not using translator has() function #53510

Open petrzpav opened 2 days ago

petrzpav commented 2 days ago

Laravel Version

11

PHP Version

8.2

Database Driver & Version

No response

Description

The getCustomMessageFromTranslator function is using custom logic to check for translation messages instead of leveraging the translator's has() function.

This behavior causes an error when checking if a translation exists within the get function. Replacing this logic with the has() function would standardize the check and prevent such errors.

Reference: Laravel source

Steps To Reproduce

        $request->validate([
            'name' => 'required|string|max:255',
            'email' => 'required|email:rfc,dns|max:255|unique:users',
        ]);

Calling translator get() instead of translator has().

crynobone commented 2 days ago

Hey there, thanks for reporting this issue.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?

Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!