laravel / framework

The Laravel Framework.
https://laravel.com
MIT License
32.64k stars 11.04k forks source link

Artisan Command Testing - Match default table style #53527

Closed MizouziE closed 6 days ago

MizouziE commented 1 week ago

This PR is to match default table style to what Illuminate\Console\Concerns\InteractsWithIO::$output->table() uses.

Recently while writing tests for an Artisan command table output I needed to dig a little to find that the default value for the 'expectsTable()'s parameter$tableStyle` did not align with the default value being used in the corresponding method that creates tables when writing a command.

I did fix it, in my case, by simply providing the correct value, but this change would allow future artisans to rely on the default values.

taylorotwell commented 6 days ago

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!