search

laravel / framework

The Laravel Framework.
https://laravel.com
MIT License
32.64k stars 11.04k forks source link

[11.x] Add lrange method to PhpRedisConnection and corresponding tests #53544

Closed rajmundtoth0 closed 3 days ago

rajmundtoth0 commented 5 days ago

This PR defines the lrange function in PhpRedisConnection class, instead of letting it pass to the __call(... method.

Benefits

Why This Change Doesn't Break Existing Features It is using the same function declaration as the underlying client expects, the feature was already there, just not defined.

How It Makes Building Web Applications Easier By enhancing autocompletion and suggestions and better test coverage.

taylorotwell commented 3 days ago

Need better reasoning why we should add this. Should we add every single Redis command that exists?

rajmundtoth0 commented 3 days ago

Some methods are defined there, some are just passed through __call. I am happy to define all the missing ones, so it will be consistent.