laravel / homestead

MIT License
3.86k stars 1.45k forks source link

Implement WSL-specific commands and documentation updates for wsl installation #1956

Closed karmendra closed 7 months ago

karmendra commented 7 months ago
svpernova09 commented 7 months ago

Looks like a couple of changesin bin/wsl-init other than the rename to bin/wsl-init.sh (which I don't think we need. Line 1 of the script contains the info).

Can you back out your changes to bin/wsl-init and keep the rest of the changes? I want to get this and #1949 together in the same branch.

svpernova09 commented 7 months ago

Let's target branch wsl-rework with this PR as the feature branch for this work.

karmendra commented 7 months ago

Looks like a couple of changesin bin/wsl-init other than the rename to bin/wsl-init.sh (which I don't think we need. Line 1 of the script contains the info).

I delete wsl-init.sh, for now. If you need any change from wsl-init.sh moved in wsl-init let me know. I had following in wsl-init.sh

  1. Changing current working directory to Homestead directory
  2. Configured logging
  3. Lot of validations (sudo, Ubuntu version, WSL_USER_NAME and WSL_USER_GROUP validations)
  4. I had defaulted the script to install mysql instead of mariadb.

Can you back out your changes to bin/wsl-init and keep the rest of the changes? I want to get this and #1949 together in the same branch.

I didn't modify wsl-init in this PR.

karmendra commented 7 months ago

I fixed the merge conflicts, Also added code in WSLCreateSiteCommand to configure cron for laravel scheduler.

Please mind that I come from bitbucket background, so pardon my ignorance with github, guide me when required. Thanks.

MichaelBelgium commented 7 months ago

There's still something wrong with the merge i think, it like completely failed or something

For instance

https://github.com/laravel/homestead/blob/wsl-rework/scripts/features/postgresql.sh

MichaelBelgium commented 7 months ago

If I checkout your branch @karmendra (document-wsl-install) and (hard) reset to commit cebcad8f7fb1b5dda78e472dfd8a62bfd77de66c, then after - when I merge wsl-rework I get these conflicts and edited files:

Conflict:

Edited:

karmendra commented 7 months ago

There is something not straight forward, allow me today, I will fix it.

karmendra commented 7 months ago

I tried various git commands to fix this, but didn't work.

So I created a fresh PR to wsl-work branch itself.

We can discard this PR and use the new one.

svpernova09 commented 6 months ago

Thanks for the work here.