Closed sebastiaanluca closed 6 months ago
Thanks @sebastiaanluca. Assigning @nunomaduro here.
The command horizon:restart
is not something we provide with Horizon. So, I must assume is something you have coded in your side. You need to adapt your command to the new output provided by php artisan horizon:status
.
The command
horizon:restart
is not something we provide with Horizon. So, I must assume is something you have coded in your side. You need to adapt your command to the new output provided byphp artisan horizon:status
.
After some thorough research (finding the command in our own codebase), I must conclude that's exactly the case 😆 Sorry all, didn't pay much attention here. The exceptions linked directly to Horizon without any trace of our command, so skipped that check.
Do agree with https://github.com/laravel/horizon/pull/1387#issuecomment-1946580755 here a bit, it could be considered a breaking change.
Hey @sebastiaanluca, please see my reply here: https://github.com/laravel/horizon/pull/1387#issuecomment-1946633038
Horizon Version
5.23.0
Laravel Version
10.44.0
PHP Version
8.2.15
Redis Driver
PhpRedis
Redis Version
2.2.2
Database Driver & Version
mysql Ver 8.1.0 for macos14.0 on arm64 (Homebrew)
Description
It seems https://github.com/laravel/horizon/pull/1387 broke the output of the
php artisan horizon:restart
command (and maybe others).We restart Horizon every so often via a scheduled job and after the update from yesterday we've been getting these in production. So it's interpreting the status message as output instead of the status code?
Confirmed it still works on v5.22.1.
The exceptions:
Steps To Reproduce
In one terminal shell:
In another: