search

laravel / horizon

Dashboard and code-driven configuration for Laravel queues.
https://laravel.com/docs/horizon
MIT License
3.83k stars 643 forks source link

Use class binding in HorizonCommand #1390

Closed v1nc3nt67 closed 6 months ago

v1nc3nt67 commented 6 months ago

This pull request modify the horizon command to permit class binding to the MasterSupervisor.

Reason: Modifying Laravel\Horizon\MasterSupervisor require changes to the HorizonCommand which will cause unnecessary issues when upgrading

taylorotwell commented 6 months ago

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

v1nc3nt67 commented 6 months ago

@taylorotwell do you think modifying the HorizonCommand class to use class injection instead of calling the class directly would be a better approach? I don't think it's a 5.x modification as this could be breaking but for 6.x If yes, how should I send in a PR for 6.x