laravel / horizon

Dashboard and code-driven configuration for Laravel queues.
https://laravel.com/docs/horizon
MIT License
3.83k stars 643 forks source link

Add job retry panel to under job information #1397

Closed CharlesBilbo closed 5 months ago

CharlesBilbo commented 5 months ago

This pull request relocates the retry widget shifting it from the bottom of the page to a more prominent position beneath the job information section. While seemingly minor, this adjustment addresses a significant issue. Myself and several colleagues, were unaware of its existence due to its placement at the page's bottom. Particularly with larger payloads, it was effectively concealed.

image

CharlesBilbo commented 5 months ago

I wasnt sure if i needed to recompile the app.js or if thats done when the code is merged

lukasyelle commented 5 months ago

Definitely would find this useful! 👍

driesvints commented 5 months ago

I wasnt sure if i needed to recompile the app.js or if thats done when the code is merged

That's all done automatically.

taylorotwell commented 5 months ago

Doesn't this just mean now that the sections you moved to the bottom would be "undiscovered"?

CharlesBilbo commented 5 months ago

not really since those components are present at all time while this one only appears when the button is clicks and is easily missed since there's not an indication that the job was retried.