search

laravel / horizon

Dashboard and code-driven configuration for Laravel queues.
https://laravel.com/docs/horizon
MIT License
3.87k stars 658 forks source link

[5.x] Update to bootstrap 5.1 and drop jQuery #1405

Closed mmachatschek closed 7 months ago

mmachatschek commented 8 months ago

This is the backported version of PR #1119

Visual comparison:

Before:

Bildschirmfoto 2024-04-04 um 21 30 58

After:

Bildschirmfoto 2024-04-04 um 21 31 06

before:

Bildschirmfoto 2024-04-04 um 21 31 27

after:

Bildschirmfoto 2024-04-04 um 21 31 38

before:

Bildschirmfoto 2024-04-04 um 21 31 52

after:

Bildschirmfoto 2024-04-04 um 21 31 58
github-actions[bot] commented 8 months ago

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

mmachatschek commented 7 months ago

@driesvints this is the resubmitted version of PR https://github.com/laravel/horizon/pull/1119

I currently don't have a full horizon setup available so I can not test this thoroughly enough. If you are ok with that, I could leave it open to others to pick up the work and add the final touches.

I explicitly set the bootstrap version to v5.1 as I originally only did the changes for boostrap v5.1, the 5.2 changes can be made in a followup PR by others. although I think maybe for v6 a complete overhaul with a new tailwind made ui is probably the way to go

driesvints commented 7 months ago

Hey @mmachatschek. Thank you for your efforts. I unfortunately also don't have the time atm. Would be great if anyone could help out here.

mmachatschek commented 7 months ago

@driesvints i setup two basic laravel horizon apps on my side and pointed to the same horizon process just with different published versions of the ui. The visual comparison is fairly the same (after some tiny modifications) now.

Generally bootstrap made the ui a little bit denser so thats kind of a good point.

From my side its now ready for review

driesvints commented 7 months ago

@mmachatschek might be a bit too much for you but any chance you can undo all of these indenting changes in the vue files etc? Would make this PR a whole lot smaller and easier to review.

mmachatschek commented 7 months ago

@driesvints sorry about that, VScode applies auto formatting. I convert the PR to draft and reapply the changes. A checked-in prettier config would be nice so that editors automatically pick that up and don't mess up the code

driesvints commented 7 months ago

@mmachatschek yeah we don't have a default one because we don't use prettier directly but styleci