Closed mmachatschek closed 7 months ago
Thanks for submitting a PR!
Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.
Pull requests that are abandoned in draft may be closed due to inactivity.
Fixes #1425 Fixes #1426
There were already tries to integrate Vite with telescope which have been postponed because of the linked issues and other concerns. I think this PR now solves all of these issues.
@timacdonald I would love to hear your opinion as well as you were involved in a lot of these discussions as well:
app.129hg41.js
. Without the cleanup, users would end up with a lot of outdated files published by packages like laravel/horizon and laravel/telescopenpm run dev
commands which this version of the vite implementation resolvesalso related:
Screenshots:
Running vite dev mode renders the "none" vite url
Setting a custom ASSET_URL works: