search

laravel / horizon

Dashboard and code-driven configuration for Laravel queues.
https://laravel.com/docs/horizon
MIT License
3.82k stars 636 forks source link

Feature Request: Warn the user if no supervisor configuration is present in the selected environment #1447

Closed yudikubota closed 1 month ago

yudikubota commented 1 month ago

I just spent an awful lot of time trying to debug why horizon was not running just to realize I was on staging environment and there was no staging supervisors...

I think it would be nice to warn the user if no supervisors are configured.

driesvints commented 1 month ago

But doesn't the dashboard show no supervisors in the list in that scenario?

yudikubota commented 1 month ago

But doesn't the dashboard show no supervisors in the list in that scenario?

Yeah, but I didn't check the dashboard, only the CLI as it was running inside a docker container for staging environment.

This is a feature request for the CLI. Something like:

php artisan horizon

INFO  Horizon started successfully.  

WARN no supervisor configuration for environment "staging"

I ask you to consider reopening this issue. Maybe other people stumble upon this exact mistake.

driesvints commented 1 month ago

Ah right, I understand. Yeah I can see that being useful, feel free to attempt a PR 👍

yudikubota commented 1 month ago

Ah right, I understand. Yeah I can see that being useful, feel free to attempt a PR 👍

Just made my first PR to this repo.