search

laravel / horizon

Dashboard and code-driven configuration for Laravel queues.
https://laravel.com/docs/horizon
MIT License
3.82k stars 636 forks source link

Update runningProcesses to also include terminating processes #1454

Closed nckrtl closed 1 month ago

nckrtl commented 1 month ago

This PR is an alternative for https://github.com/laravel/horizon/pull/1433 which both solve https://github.com/laravel/horizon/issues/1450. The difference with this PR is that terminating processes will be included in the runningProcesses() function, as suggested by @crynobone. Whenever there is a need to check for running processes elsewhere in the project the terminating processes will be included by default, instead of having to keep adding an additional check for terminating process like the other PR does https://github.com/laravel/horizon/pull/1433.

nckrtl commented 1 month ago

Tests are passing locally, are the unsuccessful checks a matter of re-running them?

driesvints commented 1 month ago

@nckrtl seems to specifically fail on the PHP 8.3 and L11 combo. Wondering why 🤔

crynobone commented 1 month ago

It probably has something to do with Symfony Process 7.1.0 (which just released few hours ago).

driesvints commented 1 month ago

@nckrtl this is now fixed on 5.x, can you rebase?

taylorotwell commented 1 month ago

We'll give it a shot. 👍