laravel / horizon

Dashboard and code-driven configuration for Laravel queues.
https://laravel.com/docs/horizon
MIT License
3.84k stars 645 forks source link

Add missing keys that should be cleared when running `horizon:clear-metrics` #1482

Closed atendwa closed 1 month ago

atendwa commented 1 month ago

This update enhances the clear() method to include additional Redis keys, ensuring that the horizon:clear-metrics command comprehensively removes all relevant metrics stored in the cache.

Dashboard State Comparison

Note on Job Hashes in Cache

Currently, job hashes remain in the cache, as illustrated below. Ideally, these should also be cleared. However, removing them without flushing the entire Redis queue connection or using wildcard patterns ('*') is not feasible unless the specific keys to target are known.

A potential improvement would be to store job hashes under a specific key, such as jobs, to facilitate direct targeting.

Screenshot from 2024-07-28 09-10-00

taylorotwell commented 1 month ago

I don't think these keys are meant to be cleared by this command. Metrics is separate from the dashboard.

atendwa commented 1 month ago

Is there a command that will achieve this use case?