search

laravel / horizon

Dashboard and code-driven configuration for Laravel queues.
https://laravel.com/docs/horizon
MIT License
3.87k stars 658 forks source link

FIX #1488 : Focused line gets hightlighted [remove .vjs-tree-node:hover] #1492

Closed srennou closed 3 months ago

srennou commented 3 months ago

Hi, This is my first-ever pull request, and I’m excited to contribute! 🎉 even with the smallest change.

In this PR, I’ve addressed the issue mentioned in Issue #1488. The hover effect on table rows in the Horizon dashboard could be distracting or unnecessary, so I’ve removed ".vjs-tree-node:hover" from the CSS "./dist/app.css". This change should help create a cleaner and more focused user experience.

Thank you for considering my contribution!

driesvints commented 3 months ago

@srennou this unfortunately won't work as assets are auto compiled. As soon as this is merged assets will re-compile and this will be undone. We'll need to find a CSS solution to this I believe.

srennou commented 3 months ago

hello , @driesvints okey thank you ill fix that and make an other PR

srennou commented 3 months ago

hi , i've added &:hover { background-color: unset; } under the .vjs-tree-node in the file "./resources/sass/syntaxhighlight.scss" to overrite the hover effect cause based on "./vite.config.js" the "./dist/app.css" is not a generated asset please correct me if i'm wrong . Thank you.