search

laravel / ideas

Issues board used for Laravel internals discussions.
939 stars 28 forks source link

[Proposal] Add out of the box tests for `artisan make:auth` routes #1121

Open jrmadsen67 opened 6 years ago

jrmadsen67 commented 6 years ago

Since artisan make:auth has a controlled output, it would be very simple to write some working unit/integration tests & add to that module.

In addition to "practicing what we preach", this would be very beneficial as a learning tool for people who want to use testing but are still a bit unsure of how to get started, by giving them actual working examples to create from.

Doing something similar with Dusk isn't a bad idea, either, but perhaps we should keep this simple to start.

drbyte commented 6 years ago

Some prior issues for inspiration:

https://github.com/laravel/ideas/issues/734 https://github.com/laravel/ideas/issues/658

jrmadsen67 commented 6 years ago

that's quite sad. perhaps things have changed.

I don't believe we can actually have something that creates production code, but make silly reasons why that production code shouldn't be tested.

If this were somebody's package they were submitting there'd be a chorus, "What? No tests? Won't use!"

On Sat, Apr 14, 2018 at 9:39 AM, Chris Brown notifications@github.com wrote:

Some prior issues for inspiration:

734 https://github.com/laravel/ideas/issues/734

658 https://github.com/laravel/ideas/issues/658

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/laravel/ideas/issues/1121#issuecomment-381290806, or mute the thread https://github.com/notifications/unsubscribe-auth/AAyKxmc1uzD1eE0CLC9YFmi6xxdEQFs_ks5toUU9gaJpZM4TU2CU .

DCzajkowski commented 6 years ago

Hey, I have created a package with auth tests. Have a look here: https://github.com/DCzajkowski/auth-tests ;)