search

laravel / ideas

Issues board used for Laravel internals discussions.
938 stars 28 forks source link

[Proposal] Force LF eol in git repo and working directory #1176

Open pawelkleczek opened 6 years ago

pawelkleczek commented 6 years ago

I encountered problem working with JavaScript SpellCheck. Git forces dictionaries to change crlf to lf and it breaks it's performance in homestead. The workaround I found is adding this:

* text eol=crlf

to .gitattributes file.

pawelkleczek commented 6 years ago

okay, this problem is much deeper than I thought - I'm investigating it right now

ili101 commented 3 years ago

Laravel have conflicting configuration. .editorconfig forces the editor to save as LF, but the git client on Windows by default use CRLF.

Either remove the LF configuration from .editorconfig so Windows users can natively work with CRLF locally (Will still push to Git with LF). Or alternatively add * text=auto eol=lf to .gitattributes to force Windows user to use LF.

As it set now the .editorconfig setting is conflicting with the git default setting * text=auto