search

laravel / ideas

Issues board used for Laravel internals discussions.
938 stars 28 forks source link

[Porposal] Enhance S3 driver configuration for S3 compatible storage #1264

Open stkari opened 6 years ago

stkari commented 6 years ago

The default configuration for filesystem S3 driver could be enhanced by adding an specific endpoint.

's3' => [ 'driver' => 's3', 'key' => env('AWS_ACCESS_KEY_ID'), 'secret' => env('AWS_SECRET_ACCESS_KEY'), 'region' => env('AWS_DEFAULT_REGION'), 'bucket' => env('AWS_BUCKET'), 'endpoint' => env('AWS_ENDPOINT'), // added 'url' => env('AWS_URL'), ],

Advantage is to support automatically S3 compatible storage system from other providers. There are some S3 compatible object storage systems available outside from AWS. If you do not add this endpoint the aws sdk automatically uses an AWS url.

sisve commented 6 years ago

Do you need a discussion for this; or could you just send a PR with the changes necessary?

stkari commented 6 years ago

I don‘t need a discussion. I’ll send a PR

greimers commented 3 years ago

@stkari Did you ever create that PR? Because I just spend 2 hours to find out that there is this hidden endpoint key that I need to use to set a custom S3 service host. I think this option really should be in the config file or at least mentioned in the docs.