laravel / ideas

Issues board used for Laravel internals discussions.
939 stars 28 forks source link

Notification toBroadcast($notifiable) must include its own timestamps #1299

Open junaid-A-khan opened 6 years ago

junaid-A-khan commented 6 years ago

I think it would be better to include timestamps a notification is broadcasted, instead of adding timestamps manually in toBroadcast($notifiable).

This was first time of me adding real time notifications and formatting their created_at using moment.js. The issue I had was when a broadcasted notification arrived it did not had its required timestamp and only its formatting glitched out because it was getting undefined created_at and I spent hours finding the issue, so dumb of me.

Thank you Taylor and its Contributors for making Laravel so awesome.....

agusesetiyono commented 4 years ago

any update for this?