Make a bot that detect missing methods for Facades in an PR

laravel / ideas

Issues board used for Laravel internals discussions.

938 stars 28 forks source link

Make a bot that detect missing methods for Facades in an PR #2513

Open foremtehan opened 3 years ago

foremtehan commented 3 years ago

More than 1000+ PR in the laravel framework about missing facades methods : https://github.com/laravel/framework/pulls?q=docblock

So it would be nice there was a robot that scan the PR and send a comment if the author forget to add related facade's method

@taylorotwell @driesvints @GrahamCampbell

tractorcow commented 3 years ago

I made a comment at https://github.com/laravel/framework/pull/36585 that this could be checked via github checks, so that PRs are marked as failed if they fail to include any missing facade methods.

By using the same tool to both check and generate the type hints, you also provide contributors and effective tool for safely generating them in the first place.