search

laravel / ideas

Issues board used for Laravel internals discussions.
939 stars 28 forks source link

[Concern] Laravel Jetstream - Test naming convention #2611

Closed yob-yob closed 3 years ago

yob-yob commented 3 years ago

so I just tried out jetstream and I'm also trying to learn TDD.

my concern is that why would jetstream create 2 test files for ApiTokenTest? one for CreateApiTokenTest and one for DeleteApiTokenTest

wouldn't it be a good idea to just merge both tests in one file named ApiTokenTest?

this may be too specific but I'm afraid that there is somewhat a larger idea behind the reason for using this type of naming convention, so before I'll try to make a pull request to Laravel I would like to ask the reason behind such convention.

themsaid commented 3 years ago

This repo is for suggesting features to the framework. Please use the forums to post questions.