search

laravel / installer

The Laravel application installer.
https://laravel.com/docs
MIT License
646 stars 266 forks source link

Cannot Install Pest on some shells #272

Closed rajabilal555 closed 1 year ago

rajabilal555 commented 1 year ago

Installer Version

5.0.2

Description

When selecting no Starter Kit on the initial prompt, pest fails to installs on Windows Powershell. Investigating this led me to the composer docs on the caret symbol where I discovered that it has to be escaped on Windows powershell.

Screenshot 2023-08-15 223235 https://getcomposer.org/doc/articles/versions.md#caret-version

Error:

image

Steps To Reproduce

Step 1: On "Would you like to install a starter kit?" Select none for No starter kit.

Step 2: On "Which testing framework do you prefer?" Enter 1 for PEST

image

crynobone commented 1 year ago

Can you test using the following:

composer require --dev "pestphp/pest:^2.0" "pestphp/pest-plugin-laravel:^2.0"
rajabilal555 commented 1 year ago

Can you test using the following:

composer require --dev "pestphp/pest:^2.0" "pestphp/pest-plugin-laravel:^2.0"

@crynobone That also does not work

image

rajabilal555 commented 1 year ago

Since the other starter kit options do install pest correctly, I checked the breeze installer and they are using the Process constructor which handles escape characters instead of the fromShellCommandline that is used by this repo.

driesvints commented 1 year ago

We have a PR up so let's continue the discussion there. Thanks!