search

laravel / lumen-framework

The Laravel Lumen Framework.
https://lumen.laravel.com
MIT License
1.48k stars 416 forks source link

fix: correct makes http request trait methods #1238

Closed santiagoibarzabal closed 2 years ago

santiagoibarzabal commented 2 years ago

Updating the MakesHttpRequest trait so that many of its http helper methods return \Illuminate\Testing\TestResponse rather than the MakesHttpTrait class. Most of the methods are already executing $this->call() but return the complete trait rather than the TestResponse class. This works correctly in Laravel but not in Lumen.

taylorotwell commented 2 years ago

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

santiagoibarzabal commented 2 years ago

Will re-submit soon with a deeper explanation and adding tests. Thank you!