laravel / lumen-framework

The Laravel Lumen Framework.
https://lumen.laravel.com
MIT License
1.48k stars 416 forks source link

[8.x] Add missing Schedule:work command #1243

Closed plourded closed 2 years ago

plourded commented 2 years ago

Simply link the command into the service provider to make it available.

We need this commands to run the scheduler into our Kubernetes clusters. Current options of using "php artisan schedule:run" isn't working for us beacause we have a lot of microservices needing cron job and it was creating to much load on our master node.

Thanks

plourded commented 2 years ago

Hello there,

Small question, what are the steps I need to do to bring that feature into a released version of 8.x and then 9.x ?

thanks Dominic

driesvints commented 2 years ago

@plourded releases are done today.

driesvints commented 2 years ago

@plourded I noticed you sent this in to Lumen v8 which is not maintained anymore. Please send this in to v9

plourded commented 2 years ago

thanks @driesvints , I create the PR to merge 8.x into 9.x: https://github.com/laravel/lumen-framework/pull/1244

Sorry if i didn't push into the right branch, the documentation still say 8.X is the branch to push: All bug fixes should be sent to the latest version that supports bug fixes (currently 8.x) (https://laravel.com/docs/9.x/contributions#which-branch)

driesvints commented 2 years ago

@plourded you're reading the docs for Laravel (the framework). With Lumen only the latest major version receives bug fixes: https://laravel.com/docs/9.x/releases#support-policy

Screenshot 2022-08-02 at 15 10 25
plourded commented 2 years ago

@driesvints thanks