search

laravel / lumen-framework

The Laravel Lumen Framework.
https://lumen.laravel.com
MIT License
1.48k stars 420 forks source link

php artisan queue:failed-table is failing. (Affects every Illuminate\Console\MigrationGeneratorCommand). #1273

Closed Kudze closed 9 months ago

Kudze commented 9 months ago

Lumen Version

10.0.2

PHP Version

8.3.0

Database Driver & Version

No response

Description

CLI queue:failed-table fails to execute on (10.x). (Did not check from which version its broken)

image

I did some initial digging and the reason for it to not execute is because there is no joinPathsmethod in Lumen Application class. However, joinPaths method exists in Laravel Application class.

This method is being used from MigrationGeneratorCommand.

I would love an opportunity to appear in contributors list, therefore I could push pull request that resolves this issue.

By the way, the method is not mentioned in ApplicationContract. Maybe it should be mentioned inside contract if its used from another composer package?

So I would just add joinPaths methods to Lumen Application class. (I would also update other path functions to utilise this function when merging paths like in Laravel Application class)

Steps To Reproduce

  1. Create new lumen project: composer create-project --prefer-dist laravel/lumen blog
  2. Execute the (example) cli: php artisan queue:failed-table
driesvints commented 9 months ago

We'd appreciate a PR here 👍

By the way, the method is not mentioned in ApplicationContract. Maybe it should be mentioned inside contract if it's used from another composer package?

I don't think we should take immediate action here.

github-actions[bot] commented 9 months ago

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

crynobone commented 9 months ago

Hi there,

Can you please upgrade to latest console and filesystem releases, this issue should be fixed.