Unable to interpret update XXX in Multilingualism - Githubissues

laravel / nova-issues

554 stars 35 forks source link

Unable to interpret update XXX in Multilingualism #1598

Closed zeroaiia closed 5 years ago

zeroaiia commented 5 years ago

Laravel Version: 5.8.16
Nova Version: 2.0.4
PHP Version: 7.2

Description:

when i upgrade to nova 2.0.4 the Multilingualism has no effect , eg:

1. Set the default language to zh-CN
1. Set resource singularLable is "你好，世界"
1. The resource button's Translate into ”Update 你好，世界“ on form

i thougth maybe something wrong with the function __(key,replace) in resource/js/base.js

hope to fix it !

bolechen commented 5 years ago

add the new translate string to zh_CN.json file

    "New :resource": "新建 :resource",
    "Update :resource": "更新 :resource",

zeroaiia commented 5 years ago

add the new translate string to zh_CN.json file
    "New :resource": "新建 :resource",
    "Update :resource": "更新 :resource",

it's done ! thanks !

by the way the en.json file has no the keys 'New :resource', 'Edit :resource', 'Update :resource'

bolechen commented 5 years ago

cc @davidhemphill

bolechen commented 5 years ago

2.0.5 fixed this issue

davidhemphill commented 5 years ago

This should be fixed in the latest release.