Localization: singular translation not respected on a relations table

laravel / nova-issues

554 stars 34 forks source link

Localization: singular translation not respected on a relations table #2526

Closed NickBelhomme closed 4 years ago

NickBelhomme commented 4 years ago

Laravel Version: 7.6.2
Nova Version: 3.4.0
PHP Version: 7.4.3
Operating System and Version: php:7.4.2-fpm-buster
Browser type and version: Chrome

Description:

Re-opening of issue: https://github.com/laravel/nova-issues/issues/847 as stated on the ticket itself: "There have been lots of improvements to Nova in terms of localization. If the issue persists, please post a new issue. Thanks!"

Steps To Reproduce:

See previous ticket.

NickBelhomme commented 4 years ago

currently I am resolving this by doing the following:

HasMany::make(trans('resources.Adoptions'), 'adoptions', AdoptionResource::class)->singularLabel(AdoptionResource::singularLabel()),

But that is something what should be automatic as the labels are set on the AdoptionResource already.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.