search

laravel / nova-issues

553 stars 34 forks source link

Accessibility: Multiple h1 elements #3429

Closed sedlatschek closed 3 years ago

sedlatschek commented 3 years ago

Description:

Having more than one h1 heading makes it hard for blind users to grasp the page contents. There should be only one h1 which then describes the contents of the current page.

Currently every panel has an h1 heading. Please use h2+ instead.

image

Laravel Nova is not accessible. This is a problem in enterprise environments, where accessibility is a must requirement.

davidhemphill commented 3 years ago

HTML5 permitted multiple H1 elements because of the semantics provided by the element types added in the spec. It would be most helpful for the requests to provide a link to a reputable source for the information offering the alternatives.

It would also be appreciated to discontinue adding "Laravel Nova is not accessible. This is a problem in enterprise environments, where accessibility is a must requirement." to every PR. You have overstated your point. :-)

davidhemphill commented 3 years ago

👋 Hi there! In order to keep this repository focused on bug reports, we auto-close feature requests and requests for help. Feel free to post your feature requests so others can discuss and add reactions. We'll keep an eye on them for later planning.

sedlatschek commented 3 years ago

Hey, thanks for your reply. You're right, HTML5 permits multiple H1 elements, yet Mozilla considers using multiple H1 not a best practice. From a accessibility standpoint I have to agree, as screenreaders like JAWS just read out every headline there is in a hierarchical order. It's not that big of an issue though, as it's not a dealbreaker for accessibility. It would be just a QoL change for blind users.

I'm not that deep into the Nova source code. Are there any downsides (besides the obvious work that has to go into it) to have all panels besides the main panel have an H2 instead of an H1 headline in the detail view?

Sorry for my last comment. I have to admit that I was somewhat frustrated yesterday. We just had an accessibility audit done on our first application that uses Nova and the results were not that great (see my other accessibility issues). I had to implement some nasty JS hacks to even be allowed to launch the product. I would be more than happy to contribute or test regarding those accessibility issues.

davidhemphill commented 3 years ago

Hey, I appreciate you bringing this to our attention. It is something we care about, but is admittedly pretty difficult to find reputable information that doesn't conflict with other reputable sources. 😅

We will be making a big accessibility sweep across the product in the coming months in preparation for the next release. We will likely bring those changes to the 3.x branch in Orion where it makes sense.

github-actions[bot] commented 2 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.