laravel / nova-issues

557 stars 34 forks source link

Tag field displayAsList on Resource Index & Details in dark mode #4984

Closed dmason30 closed 2 years ago

dmason30 commented 2 years ago

Description:

Tag::make(trans('fields.branch'), 'branches', BranchResource::class)
 ->withPreview()
 ->displayAsList()
 ->nullable()

Hovering over the field on details in dark mode: image

Seems adding dark:hover:bg-gray-900 to the button is the fix image

Could do with some padding though adding p-2 to the button yields this: image

Also has this issue when hovering over the resource on index: image

mrleblanc101 commented 2 years ago

For me, the field is completely misaligned when using displayAsList. Not quite sure if it's related or a seperate issue. Capture d’écran, le 2022-10-31 à 16 39 02

mrleblanc101 commented 2 years ago

Also I'm not sure why the text is smaller. Or why the Resource are not links like most other linkable columns (See "Award Category" in the screenshot).

mrleblanc101 commented 2 years ago

I'm still having alignment issue in 4.18.1 The text size is still not uniform. The resource is still not clickable.

Capture d’écran, le 2022-11-02 à 15 53 38

I would expect it to be like this: Capture d’écran, le 2022-11-02 à 15 55 53

mrleblanc101 commented 2 years ago

Sorry for the confusion, my composer update did not update Nova to the lastest version because of nova-kit require <4.18.0 so I'm still on 4.17.1 😞

"name": "nova-kit/nova-packages-tool",
"require": {
    "laravel/nova": ">=4.16.0 <4.18.0",
    "php": "^7.3 || ^8.0"
},
mrleblanc101 commented 2 years ago

@davidhemphill Ok, now I'm on 4.18.1 and the alignment is changed, but still wrong imho. Capture d’écran, le 2022-11-02 à 16 16 25

mrleblanc101 commented 2 years ago

Still an issue in 4.18.2, will open a new ticket

github-actions[bot] commented 2 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.