laravel / nova-issues

554 stars 34 forks source link

Some Heroicons are not rendered proper #5139

Closed scramatte closed 1 year ago

scramatte commented 1 year ago

Description:

Some Hero icons are rendered incorrectly such : calculator, fingerprint or cube

Border color and fill need to be fixed into Heroicons .vue components . As you can see bellow. stroke should be set to "none" instead of "currentColor" and fill to "currentColor" instead of "#374151"

HeroiconsOutlineCalculator.vue

<template>
  <svg
    xmlns="http://www.w3.org/2000/svg"
    fill="none"
    viewBox="0 0 24 24"
    stroke="currentColor"
    width="24"
    height="24"
  >
    <path
      fill="#374151"
      d="M9 6a1 1 0 000 2V6zm6 2a1 1 0 100-2v2zm-1 9a1 1 0 102 0h-2zm2-3a1 1 0 10-2 0h2zm-4 2a1 1 0 100 2v-2zm.01 2a1 1 0 100-2v2zM9 16a1 1 0 100 2v-2zm.01 2a1 1 0 100-2v2zM9 13a1 1 0 100 2v-2zm.01 2a1 1 0 100->
    />
  </svg>
</template>

Examples of incorrect rendering

image image

Detailed steps to reproduce the issue on a fresh Nova installation:

Just install fresh nova and set menu icon as calculator, fingerprint or cube for example. I haven't got a la list of all incorrect icons.

crynobone commented 1 year ago

Fixed and will be part of the next release.

silver-surfer test-NovaSite-IconsViewer(2)

scramatte commented 1 year ago

Thank you

github-actions[bot] commented 1 year ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.