search

laravel / nova-issues

556 stars 34 forks source link

Layout/Auth.vue doesnt respect darkMode #5505

Closed whipsterCZ closed 1 year ago

whipsterCZ commented 1 year ago

Description:

If i have selected Dark mode i cant see my AppLogo ( it uses svg with fill="currentColor") so my logo is Black on dark background....

but i the layout /vendor/laravel/nova/resources/js/layouts/Auth.vue there is hardcoded class text-black for color property...

<template>
  <div class="py-6 px-1 md:px-2 lg:px-6">
    <div class="mx-auto py-8 max-w-sm flex justify-center text-black">
      <AppLogo class="h-8" />
    </div>
...

I have spent 8+ hours to override this behaviour and due the architecture I was unable to do it...

can you please fix it ? its one-liner..

And it will be cool to have option how to override these Layouts somehow....

FIX

Just remove this class.. everything works as expected...

    <div class="mx-auto py-8 max-w-sm flex justify-center ">
simon-roland commented 1 year ago

@whipsterCZ Check out https://github.com/Muetze42/nova-assets-changer

It lets you override the vue components of Nova 4

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

whipsterCZ commented 1 year ago

but this component cannot be overriden ( its called directly) It is not registered into Vue.components()

github-actions[bot] commented 1 year ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.