search

laravel / nova-issues

556 stars 34 forks source link

mixed pseudoclass being used in \Laravel\Nova\Fields\Field::fillModelWithData #5658

Closed jaewun closed 1 year ago

jaewun commented 1 year ago

Description:

mixed pseudoclass type hints are only supported from PHP 8

Seems like 4.26 introduced these with \Laravel\Nova\Fields\Field::fillModelWithData

Causes the following error

Argument 1 passed to Laravel\Nova\Fields\Field::fillModelWithData() must be an instance of Laravel\Nova\Fields\mixed, instance of Illuminate\Database\Eloquent\Relations\Pivot given, called in /var/www/vendor/laravel/nova/src/Fields/Field.php on line 475

Detailed steps to reproduce the issue on a fresh Nova installation:

Noticed it while trying to attach a pivot resource. Not sure it needs reproducing, the mixed typehints just need to be removed as they're not supported in ^7.3 (php versions supported in composer.json)

github-actions[bot] commented 1 year ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.