search

laravel / nova-issues

556 stars 34 forks source link

filters not shown #6116

Closed mshtroylab closed 10 months ago

mshtroylab commented 11 months ago

Description:

in version 4.32.6 resource filters work fine but in 4.32.11 all filters have hidden

Detailed steps to reproduce the issue on a fresh Nova installation:

1- add filter to any resource 2- try to use this filter

Screenshot_5 Screenshot_4

crynobone commented 11 months ago

Unable to reproduce the issue, please provide full reproducing repository based on fresh installation as suggested in the bug report template (or you can refer to https://github.com/nova-issues for example)

superuser-me commented 11 months ago

@crynobone please check this carefully, it's broken in between 4.32.7 and 4.32.6, in 4.32.6 it was working for me, i have manually tested one by one nova versions to check which version has introduced this bug, i found 4.32.7 is the one.

i have reported this at first and now we already 2 more similar issues, https://github.com/laravel/nova-issues/issues/6109 https://github.com/laravel/nova-issues/issues/6093 https://github.com/laravel/nova-issues/issues/6116

jeffcaulfield-morphsites commented 11 months ago

I'm experiencing the same issue in 4.32.10: the custom filters are missing unless I revert to 4.32.6.

The "lens" menu also appears even though there are no lenses defined.

davidhemphill commented 10 months ago

"Create a custom filter and use it" is not 'detailed steps to reproduce'.

To diagnose and fix issues, we need to be able to reproduce them. Having detailed bug reports, and ideally, a reproduction repository is the best way to help us.

When you can provide a reproducible example on a fresh instance of Nova, we'd love to take a look and work towards a resolution!

jeffcaulfield-morphsites commented 10 months ago

I was going to attach a new sample project with a single "Email Verified" Yes/No filter on the User resource, which was essentially all I needed to reproduce this issue locally yesterday… except that now it's working (as of today). I un-pinned the actual project I'm working on from 4.32.6 and it also works with no other changes (both on 4.32.10 and 4.32.11).

The only thing I can think of is that some of the public/vendor/nova assets were somehow cached in a broken state. 🤷‍♂️

superuser-me commented 9 months ago

@jeffcaulfield-morphsites is there any other things which you have noticed in broken state? i removed cached assets, but i am still seeing the lens icon in a resource with zero lenses.

jeffcaulfield-morphsites commented 9 months ago

Sorry @superuser-me I really have no idea. I was, however, referring to browser caching of those assets rather than the assets themselves. Sorry if that doesn't help.

NorthNick commented 6 months ago

I also had this problem and tracked it down to the gobrightspot/nova-detached-actions package, which has sadly been abandoned. Replacing it with the datomatic/nova-detached-actions fork fixed both the missing filters and incorrectly appearing lens menu problems. Some button restyling was needed, but otherwise it's a straight swap.