search

laravel / nova-issues

553 stars 34 forks source link

Issue when exporting resources with a slash/backslash in the filename #6185

Closed paulandroshchuk closed 8 months ago

paulandroshchuk commented 8 months ago

Description:

Noticed an issue with the CSV Export built-in action. When the name of the file has a slash or a backslash, it throws the following exception:

The filename and the fallback cannot contain the "/" and "\" characters.

If that's intended, could validation be added to that field at least? It just silently fails (no errors on the frontend, it just keeps the modal open) and you have no idea why until you manually find the error in laravel.log.

Detailed steps to reproduce the issue on a fresh Nova installation:

  1. Create a Nova resource
  2. Add CSVExport action to the resource
  3. Try to export it with a slash/backslash in the filename

CleanShot 2024-02-07 at 20 03 32@2x

github-actions[bot] commented 8 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.