search

laravel / nova-issues

554 stars 34 forks source link

Search input not working in select field for actions #6276

Closed guybrun closed 7 months ago

guybrun commented 7 months ago

Description:

Updated to Nova version 4.32.16 and discovered that the search input field does not work for select field which is searchable() in actions,

It is not possible to type in the Search input field.

Take a look at uploaded screenshot. nova-4-32-16-bug

Detailed steps to reproduce the issue on a fresh Nova installation:

crynobone commented 7 months ago

Fixed in 4.33.0

skywalker666 commented 7 months ago

Well, it still doesn't work for any searchable select field in an action. For the first one it's always opened by default (like shown in the screenshot above) and there seems to be some weird interaction with a second one when that gets opened.

guybrun commented 7 months ago

Fixed in 4.33.0 I updated to 4.33.0, but still same issue

potsky commented 7 months ago

Same problem and behavior.

6257 has fixed the global freeze but not the belongsTo freeze

meyer59 commented 7 months ago

i have opened the same issues Dec 13 and reopen one a few days ago. How arogant they are, they keep closing my issues but the problem is still here https://github.com/laravel/nova-issues/issues/6271 https://github.com/laravel/nova-issues/issues/6107

potsky commented 7 months ago

i have opened the same issues Dec 13 and reopen one a few days ago. How arogant they are, they keep closing my issues but the problem is still here #6271 #6107

Arogant I don't know, but bugs are part of the development process 😇 Even if we pay for Nova, there will always be some bugs. This is normal.

We just need to be constructive to help them to find and fix bugs. I know this is annoying, my sales team of 10 people is currently blocked due to this bug, they cannot import electrical powers and consumption of French companies but we can just wait for the Nova team to fix the problem.

The actual bug is a common regression in Nova on BelongsTo fields. It was already the case on December #6113 then after it works agains and finally not!

In #6097 @davidhemphill said https://github.com/laravel/nova-issues/issues/6097#issuecomment-1863276012

It seems the previous fix was just a strap...

animena commented 7 months ago

same issue here, and blocking me from deadline, looks like I have to modify the code until this one is fixed

goldmerc commented 7 months ago
puzzledmonkey commented 7 months ago

same issue here.

honestly, sorry to bring this up as i'm sure everyone agrees, but if this has been an issue since 4.32.16, why is it not already in your dusk test cases - specifically the "BelongsTo searchable in an Action popup" case that STILL causes this issue on 4.33.0?

it's quite frustrating that we cannot rely on simple functionality like this in a paid product such as Nova.

mostafaznv commented 7 months ago

I believe this issue is related to #6242 I reported it a couple of days ago, and while they released some fixes, the problem persists.

Please refer to that issue for a detailed explanation, including a reproduction repository and a video demonstrating the problem.

Edit: it doesn't work with 4.33.0 either

SamMakesCode commented 7 months ago

Sorry, I'm confused. I'm sure something similar was fixed in v4.33.0 but almost almost unanimously people here are saying this particular issue isn't fixed.

@crynobone has marked this as fix incoming, does that means there's a fix coming in v4.33.1?

I'm running v4.33.0 and am unable to focus on the search field when using searchable on the Select nova field type. I can also confirm this issue doesn't occur in v4.32.11

potsky commented 7 months ago

Sorry, I'm confused. I'm sure something similar was fixed in v4.33.0 but almost almost unanimously people here are saying this particular issue isn't fixed.

@crynobone has marked this as fix incoming, does that means there's a fix coming in v4.33.1?

I'm running v4.33.0 and am unable to focus on the search field when using searchable on the Select nova field type. I can also confirm this issue doesn't occur in v4.32.11

This is not fixed in v4.33.0 We certainly have to wait for the next version.

puzzledmonkey commented 7 months ago

Hey @crynobone or @davidhemphill is there any ETA on getting this fix released? You've previously released point releases with single bug fixes, and this issue is really breaking functionality. Is there any chance of making a point release to fix this issue in particular?

github-actions[bot] commented 7 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.