Incorrect method call for Batch Action in "toQueryWithoutScopes" method

[dzandrey]

• Laravel Version: 11.3.1
• Nova Version: 4.33.3
• PHP Version: 8.2

Description:

In Laravel Nova when attempting to retrieve selected resource IDs through the selectedResourceIds() method, an issue with incorrect processing of the comma-separated string of identifiers has been discovered.

• file: vendor/laravel/nova/src/Http/Requests/InteractsWithResourcesSelection.php

• method: selectedResourceIds()

  The issue lies in the improper conversion of the string containing identifiers into an array, leading to incorrect logic in determining the number of selected resources and subsequent erroneous invocation of the detailQuery or indexQuery methods in the ActionRequest class.

• file: vendor/laravel/nova/src/Http/Requests/ActionRequest.php
• method: toQueryWithoutScopes()

Detailed steps to reproduce the issue on a fresh Nova installation:

Open resource index page and apply any Action to multiple records

[crynobone]

Unable to reproduce the issue, please provide full reproducing repository based on fresh installation as suggested in the bug report template (or you can refer to https://github.com/nova-issues for example)

[crynobone]

For context, Nova would only send a string as all or an array of IDs, so comma separated string is not an expectwd behaviour. This has been tested vja our integration and dusk tests. You need to submit reproduing code to confirm such issue exist.

[dzandrey]

@crynobone https://github.com/dzandrey/nova-issue-batch-action

[crynobone]

The usage of selectedResourceIds() is limited to Action Modal confirmation and not during submission and therefore isn't a bug. You should look at toSelectedResourceQuery() on how to access it, since all methods here are internal we not making changes to the above method.

[dzandrey]

Here is the method you're referring to. But it uses toQueryWithoutScopes() from which it takes $resource::detailQuery instead of $resource::indexQuery. In this case, $resource::indexQuery should be triggered because I am calling the action on the list and not on the detail page.