Empty NOVA_PATH should be handled

AbdelkaderBah commented 5 months ago

Laravel Version: 10.48.12
Nova Version: 4.34.2
PHP Version: 8.2
Database Driver & Version: MYSQL 8.0
Operating System and Version: WSL Debian
Browser type and version: Chrome 126

Description:

First it might sound stupid to have NOVA_PATH empty, I have just git pulled, and copied .env.example to .env set few environments and forgot NOVA_PATH and I got 500 server error, after digging I found that it's because NOVA_PATH is null.

When an empty NOVA_PATH is provided, Nova should thrown an exception with meaningful error message .

Currently it gives:

Trying to access array offset on value of type bool

That's because Laravel\Nova\Util tries to access isset($uri['port']) on line 34

Detailed steps to reproduce the issue on a fresh Nova installation:

Set environment
```
NOVA_PATH=
```
Access your app / url.

crynobone commented 5 months ago

Use NOVA_PATH=/

AbdelkaderBah commented 5 months ago

Actually I am leaving it to NOVA_PATH= on purpose,

The admin path is a secret path that only internals knows about
If it is empty the admin should not be accessible

laravel / nova-issues

Empty NOVA_PATH should be handled #6449

Description:

Detailed steps to reproduce the issue on a fresh Nova installation: